Skip to content

feat: event with ongoing occurrences can have space for enrolment#425

Merged
charn merged 1 commit into
mainfrom
PT-1952/fix-full-events
Sep 8, 2025
Merged

feat: event with ongoing occurrences can have space for enrolment#425
charn merged 1 commit into
mainfrom
PT-1952/fix-full-events

Conversation

@charn

@charn charn commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

An event with ongoing occurrences can have space for enrolment if the enrolement hasn't been set to end before an occurence starts.

Refs: PT-1952

@charn charn requested a review from a team as a code owner September 5, 2025 14:06
@terovirtanen

terovirtanen commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

KULTUS-API branch is deployed to platta: https://kultus-pr425.api.dev.hel.ninja 🚀🚀🚀

@charn charn force-pushed the PT-1952/fix-full-events branch 2 times, most recently from 2f07ffa to 5e8c085 Compare September 5, 2025 18:54
@terovirtanen

terovirtanen commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

KULTUS-API branch is deployed to platta: https://kultus-pr425.api.dev.hel.ninja 🚀🚀🚀

@charn charn force-pushed the PT-1952/fix-full-events branch 3 times, most recently from 2de9fe0 to 8619096 Compare September 5, 2025 20:23
@terovirtanen

terovirtanen commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

KULTUS-API branch is deployed to platta: https://kultus-pr425.api.dev.hel.ninja 🚀🚀🚀

@charn charn force-pushed the PT-1952/fix-full-events branch from ff0236f to ead275c Compare September 5, 2025 20:52
@terovirtanen

terovirtanen commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

KULTUS-API branch is deployed to platta: https://kultus-pr425.api.dev.hel.ninja 🚀🚀🚀

@charn charn force-pushed the PT-1952/fix-full-events branch 3 times, most recently from 33a6ef3 to 5a9c824 Compare September 7, 2025 19:47
@terovirtanen

terovirtanen commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

KULTUS-API branch is deployed to platta: https://kultus-pr425.api.dev.hel.ninja 🚀🚀🚀

@charn charn force-pushed the PT-1952/fix-full-events branch from 5a9c824 to c5738df Compare September 8, 2025 07:26
@terovirtanen

terovirtanen commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

KULTUS-API branch is deployed to platta: https://kultus-pr425.api.dev.hel.ninja 🚀🚀🚀

voneiden
voneiden approved these changes Sep 8, 2025
View reviewed changes

@voneiden voneiden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, one missing whitespace 🕵️

Comment thread occurrences/models.py Outdated
@charn
feat: event with ongoing occurrences can have space for enrolment
dc03e97 
An event with ongoing occurrences can have space for enrolment if
the enrolement hasn't been set to end before an occurence starts.

Refs: PT-1952
@charn charn force-pushed the PT-1952/fix-full-events branch from c5738df to dc03e97 Compare September 8, 2025 09:07
@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@terovirtanen

terovirtanen commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

KULTUS-API branch is deployed to platta: https://kultus-pr425.api.dev.hel.ninja 🚀🚀🚀

@charn charn merged commit 4405b23 into main Sep 8, 2025
19 of 22 checks passed
@charn charn deleted the PT-1952/fix-full-events branch September 8, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@voneiden voneiden voneiden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charn @terovirtanen @voneiden